Switch SchemeIsSecure to SchemeIsCryptographic for password-manager-related code.

Switch SchemeIsSecure to SchemeIsCryptographic for password-manager-related code.

SchemeIsSecure was changed to SchemeIsCryptographic in https://codereview.chromium.org/1049953003 .

BUG=362214
Committed: https://crrev.com/e59aa5de9a581a073b02f51d83078fcd6d312a30
Cr-Commit-Position: refs/heads/master@{#327410}

[lgarron, 2015-04-24 20:11:40]

lgarron@chromium.org changed reviewers:
+ palmer@chromium.org

[lgarron, 2015-04-24 20:11:40]

Mike, you're also an owner for the password code. Could you help us find out
whether SchemeIsCryptographic() is appropriate for the password manager?

[palmer, 2015-04-24 20:22:23]

https://codereview.chromium.org/1108673002/diff/1/components/password_manager...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/1108673002/diff/1/components/password_manager...
components/password_manager/core/browser/password_manager.cc:143: bool ssl_valid
= form.origin.SchemeIsryptographic();
Typo.

[Mike West, 2015-04-26 07:53:03]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-04-26 07:53:03]

This looks right for the password manager; the goal here is to ensure that we
never fill credentials saved on `https` into a form on `http`. Checking the
scheme is enough for that, we don't need the `IsOriginSecure` checks here.

LGTM.

[palmer, 2015-04-27 19:00:04]

Thanks, Mike. Looks like you can just fix that typo and CQ it, Lucas. LGTM.

[lgarron, 2015-04-27 22:09:56]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-04-27 22:10:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108673002/1

[commit-bot: I haz the power, 2015-04-27 22:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 22:19:49]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[lgarron, 2015-04-27 22:44:05]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[lgarron, 2015-04-27 22:44:06]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1108673002/#ps20001
(title: "Fix typo.")

[commit-bot: I haz the power, 2015-04-27 22:44:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108673002/20001

[commit-bot: I haz the power, 2015-04-27 23:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 23:37:05]

Dry run: This issue passed the CQ dry run.

[lgarron, 2015-04-28 23:00:37]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-04-28 23:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108673002/20001

[commit-bot: I haz the power, 2015-04-29 01:36:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 01:37:20]

Patchset 2 (id:??) landed as
https://crrev.com/e59aa5de9a581a073b02f51d83078fcd6d312a30
Cr-Commit-Position: refs/heads/master@{#327410}