components/password_manager/core/browser/password_form_manager.cc - Issue 1108673002: Switch SchemeIsSecure to SchemeIsCryptographic for password-manager-related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1108673002: Switch SchemeIsSecure to SchemeIsCryptographic for password-manager-related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_win.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 88fdc57496a20e4ae1aec3f9b047470cbec355af..57f4ae324ac5ec9b153c37684b6f8cb841734ac3 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -161,8 +161,8 @@ PasswordFormManager::MatchResultMask PasswordFormManager::DoesManage(

// we also consider the actions a match. This is to accommodate cases where

// the original login form is on an HTTP page, but a failed login attempt

// redirects to HTTPS (as in http://example.org -> https://example.org/auth).

- if (!origins_match && !observed_form_.origin.SchemeIsSecure() &&

- form.origin.SchemeIsSecure()) {

+ if (!origins_match && !observed_form_.origin.SchemeIsCryptographic() &&

+ form.origin.SchemeIsCryptographic()) {

const std::string& old_path = observed_form_.origin.path();

const std::string& new_path = form.origin.path();

origins_match =