Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface (Closed)

Created:
5 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
nduca, reveman
CC:
reveman, chromium-reviews, erikwright+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org, Sébastien Marchand, ssid, petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Simplify MemoryDumpProvider interface - Rename DumpInto(PMD*) into OnMemoryDump(PMD*) - Make the MemoryDumpProvider interface pure abstract. - Move the task_runner argument to MDM.RegisterDumpProvider(). - Remove the awkward DeclareAttribute() logic - Rename the useless MemoryDumpProvider.GetFriendlyName() method. - Adapt the existing allocators dump providers to the changes. BUG=466141 Committed: https://crrev.com/2d56df1b08b8c8439315efc3f6af2dc053db16a0 Cr-Commit-Position: refs/heads/master@{#327257}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep protected dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -275 lines) Patch
M base/trace_event/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/java_heap_dump_provider_android.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/java_heap_dump_provider_android.cc View 3 chunks +1 line, -6 lines 0 comments Download
M base/trace_event/malloc_dump_provider.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/malloc_dump_provider.cc View 3 chunks +1 line, -11 lines 0 comments Download
M base/trace_event/memory_allocator_dump_unittest.cc View 3 chunks +2 lines, -17 lines 0 comments Download
M base/trace_event/memory_dump_manager.h View 5 chunks +21 lines, -11 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 7 chunks +55 lines, -43 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 7 chunks +43 lines, -73 lines 0 comments Download
M base/trace_event/memory_dump_provider.h View 1 2 chunks +8 lines, -41 lines 0 comments Download
D base/trace_event/memory_dump_provider.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider.cc View 3 chunks +1 line, -9 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/process_memory_totals_dump_provider.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/process_memory_totals_dump_provider.cc View 3 chunks +1 line, -7 lines 0 comments Download
M base/trace_event/process_memory_totals_dump_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/winheap_dump_provider_win.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/winheap_dump_provider_win.cc View 2 chunks +1 line, -5 lines 0 comments Download
M base/trace_event/winheap_dump_provider_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Primiano Tucci (use gerrit)
PTAL, this is just removing files This is part of a series of 3 CLs ...
5 years, 8 months ago (2015-04-27 22:40:28 UTC) #2
reveman
https://codereview.chromium.org/1107093004/diff/1/base/trace_event/memory_dump_provider.h File base/trace_event/memory_dump_provider.h (left): https://codereview.chromium.org/1107093004/diff/1/base/trace_event/memory_dump_provider.h#oldcode50 base/trace_event/memory_dump_provider.h:50: virtual ~MemoryDumpProvider(); Can we keep an empty protected dtor ...
5 years, 8 months ago (2015-04-27 23:01:24 UTC) #4
nduca
lgtm
5 years, 8 months ago (2015-04-28 00:25:54 UTC) #5
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1107093004/diff/1/base/trace_event/memory_dump_provider.h File base/trace_event/memory_dump_provider.h (left): https://codereview.chromium.org/1107093004/diff/1/base/trace_event/memory_dump_provider.h#oldcode50 base/trace_event/memory_dump_provider.h:50: virtual ~MemoryDumpProvider(); On 2015/04/27 23:01:24, reveman wrote: > Can ...
5 years, 7 months ago (2015-04-28 08:03:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107093004/40001
5 years, 7 months ago (2015-04-28 08:03:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-04-28 10:06:33 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 10:07:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d56df1b08b8c8439315efc3f6af2dc053db16a0
Cr-Commit-Position: refs/heads/master@{#327257}

Powered by Google App Engine
This is Rietveld 408576698