Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: base/trace_event/java_heap_dump_provider_android.cc

Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keep protected dtor Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/java_heap_dump_provider_android.h ('k') | base/trace_event/malloc_dump_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/java_heap_dump_provider_android.cc
diff --git a/base/trace_event/java_heap_dump_provider_android.cc b/base/trace_event/java_heap_dump_provider_android.cc
index aa193ab78ea07cad19e027897fac2833302c8496..759bc0461ac9eac31afd3f6873759a0ef6afbda7 100644
--- a/base/trace_event/java_heap_dump_provider_android.cc
+++ b/base/trace_event/java_heap_dump_provider_android.cc
@@ -12,7 +12,6 @@ namespace trace_event {
namespace {
-const char kDumperFriendlyName[] = "JavaHeap";
const char kDumperName[] = "java_heap";
} // namespace
@@ -31,7 +30,7 @@ JavaHeapDumpProvider::~JavaHeapDumpProvider() {
// Called at trace dump point time. Creates a snapshot with the memory counters
// for the current process.
-bool JavaHeapDumpProvider::DumpInto(ProcessMemoryDump* pmd) {
+bool JavaHeapDumpProvider::OnMemoryDump(ProcessMemoryDump* pmd) {
MemoryAllocatorDump* dump =
pmd->CreateAllocatorDump(kDumperName, MemoryAllocatorDump::kRootHeap);
@@ -45,9 +44,5 @@ bool JavaHeapDumpProvider::DumpInto(ProcessMemoryDump* pmd) {
return true;
}
-const char* JavaHeapDumpProvider::GetFriendlyName() const {
- return kDumperFriendlyName;
-}
-
} // namespace trace_event
} // namespace base
« no previous file with comments | « base/trace_event/java_heap_dump_provider_android.h ('k') | base/trace_event/malloc_dump_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698