base/trace_event/java_heap_dump_provider_android.h - Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/java_heap_dump_provider_android.h

Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep protected dtor Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/java_heap_dump_provider_android.h

diff --git a/base/trace_event/java_heap_dump_provider_android.h b/base/trace_event/java_heap_dump_provider_android.h

index 82807510b2a463d799b183400127b8c94ded1c27..5699b655853c404678fe491b8fb78d2cddb571db 100644

--- a/base/trace_event/java_heap_dump_provider_android.h

+++ b/base/trace_event/java_heap_dump_provider_android.h

@@ -17,8 +17,7 @@ class JavaHeapDumpProvider : public MemoryDumpProvider {

static JavaHeapDumpProvider* GetInstance();

// MemoryDumpProvider implementation.

- bool DumpInto(ProcessMemoryDump* pmd) override;

- const char* GetFriendlyName() const override;

+ bool OnMemoryDump(ProcessMemoryDump* pmd) override;

private:

friend struct DefaultSingletonTraits<JavaHeapDumpProvider>;

« no previous file with comments | « base/trace_event/BUILD.gn ('k') | base/trace_event/java_heap_dump_provider_android.cc » ('j') | no next file with comments »