Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1107013002: [device] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in device module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/d4d2fc18bd3c078917e0ab952a786947a4daff27 Cr-Commit-Position: refs/heads/master@{#327237}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Review Comments #

Total comments: 2

Patch Set 3 : Fixed Review Comments : Removal of message_loop_proxy header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -89 lines) Patch
M device/serial/serial_connection_factory.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M device/serial/serial_connection_factory.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler.h View 1 2 6 chunks +11 lines, -10 lines 0 comments Download
M device/serial/serial_io_handler.cc View 1 6 chunks +19 lines, -23 lines 0 comments Download
M device/serial/serial_io_handler_posix.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M device/serial/serial_io_handler_posix.cc View 1 3 chunks +11 lines, -13 lines 0 comments Download
M device/serial/serial_io_handler_win.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M device/serial/serial_service_impl.h View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M device/serial/serial_service_impl.cc View 1 1 chunk +14 lines, -16 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Pranay
PTAL
5 years, 7 months ago (2015-04-27 13:51:36 UTC) #2
Ken Rockot(use gerrit already)
Thanks for doing this! A few problems: This has SingleThreadedTaskRunners all over the place named ...
5 years, 7 months ago (2015-04-28 03:19:09 UTC) #3
Pranay
On 2015/04/28 03:19:09, Ken Rockot wrote: > Thanks for doing this! A few problems: > ...
5 years, 7 months ago (2015-04-28 04:32:11 UTC) #4
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/1107013002/diff/20001/device/serial/serial_connection_factory.h File device/serial/serial_connection_factory.h (right): https://codereview.chromium.org/1107013002/diff/20001/device/serial/serial_connection_factory.h#newcode12 device/serial/serial_connection_factory.h:12: #include "base/message_loop/message_loop_proxy.h" Oops, missed this before. Please also ...
5 years, 7 months ago (2015-04-28 05:02:02 UTC) #5
Pranay
Thanks Ken, updated the changes :)
5 years, 7 months ago (2015-04-28 05:11:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107013002/40001
5 years, 7 months ago (2015-04-28 05:11:52 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-28 06:08:29 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d4d2fc18bd3c078917e0ab952a786947a4daff27 Cr-Commit-Position: refs/heads/master@{#327237}
5 years, 7 months ago (2015-04-28 06:09:21 UTC) #11
Pranay
5 years, 7 months ago (2015-05-04 03:25:23 UTC) #12
Message was sent while issue was closed.
Done

https://codereview.chromium.org/1107013002/diff/1/device/serial/serial_connec...
File device/serial/serial_connection_unittest.cc (right):

https://codereview.chromium.org/1107013002/diff/1/device/serial/serial_connec...
device/serial/serial_connection_unittest.cc:73: base::ThreadTaskRunnerHandle
On 2015/04/28 03:19:09, Ken Rockot wrote:
> Please fix the formatting here. How does this even compile?

Done.

https://codereview.chromium.org/1107013002/diff/20001/device/serial/serial_co...
File device/serial/serial_connection_factory.h (right):

https://codereview.chromium.org/1107013002/diff/20001/device/serial/serial_co...
device/serial/serial_connection_factory.h:12: #include
"base/message_loop/message_loop_proxy.h"
On 2015/04/28 05:02:02, Ken Rockot wrote:
> Oops, missed this before. Please also remove uses of this header where
possible.
> There are a few places.

Done.

Powered by Google App Engine
This is Rietveld 408576698