Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: device/serial/serial_connection_factory.h

Issue 1107013002: [device] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Review Comments : Removal of message_loop_proxy header file Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | device/serial/serial_connection_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_SERIAL_SERIAL_CONNECTION_FACTORY_H_ 5 #ifndef DEVICE_SERIAL_SERIAL_CONNECTION_FACTORY_H_
6 #define DEVICE_SERIAL_SERIAL_CONNECTION_FACTORY_H_ 6 #define DEVICE_SERIAL_SERIAL_CONNECTION_FACTORY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/message_loop/message_loop_proxy.h" 12 #include "base/single_thread_task_runner.h"
13 #include "base/thread_task_runner_handle.h"
13 #include "device/serial/data_stream.mojom.h" 14 #include "device/serial/data_stream.mojom.h"
14 #include "device/serial/serial.mojom.h" 15 #include "device/serial/serial.mojom.h"
15 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h" 16 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h"
16 17
17 namespace device { 18 namespace device {
18 19
19 class SerialIoHandler; 20 class SerialIoHandler;
20 21
21 class SerialConnectionFactory 22 class SerialConnectionFactory
22 : public base::RefCountedThreadSafe<SerialConnectionFactory> { 23 : public base::RefCountedThreadSafe<SerialConnectionFactory> {
23 public: 24 public:
24 typedef base::Callback<scoped_refptr<SerialIoHandler>()> IoHandlerFactory; 25 typedef base::Callback<scoped_refptr<SerialIoHandler>()> IoHandlerFactory;
25 26
26 SerialConnectionFactory( 27 SerialConnectionFactory(
27 const IoHandlerFactory& io_handler_factory, 28 const IoHandlerFactory& io_handler_factory,
28 scoped_refptr<base::MessageLoopProxy> connect_message_loop); 29 scoped_refptr<base::SingleThreadTaskRunner> connect_task_runner);
29 30
30 void CreateConnection( 31 void CreateConnection(
31 const std::string& path, 32 const std::string& path,
32 serial::ConnectionOptionsPtr options, 33 serial::ConnectionOptionsPtr options,
33 mojo::InterfaceRequest<serial::Connection> connection_request, 34 mojo::InterfaceRequest<serial::Connection> connection_request,
34 mojo::InterfaceRequest<serial::DataSink> sink, 35 mojo::InterfaceRequest<serial::DataSink> sink,
35 mojo::InterfaceRequest<serial::DataSource> source, 36 mojo::InterfaceRequest<serial::DataSource> source,
36 mojo::InterfacePtr<serial::DataSourceClient> source_client); 37 mojo::InterfacePtr<serial::DataSourceClient> source_client);
37 38
38 private: 39 private:
39 friend class base::RefCountedThreadSafe<SerialConnectionFactory>; 40 friend class base::RefCountedThreadSafe<SerialConnectionFactory>;
40 class ConnectTask; 41 class ConnectTask;
41 42
42 virtual ~SerialConnectionFactory(); 43 virtual ~SerialConnectionFactory();
43 44
44 const IoHandlerFactory io_handler_factory_; 45 const IoHandlerFactory io_handler_factory_;
45 scoped_refptr<base::MessageLoopProxy> connect_message_loop_; 46 scoped_refptr<base::SingleThreadTaskRunner> connect_task_runner_;
46 47
47 DISALLOW_COPY_AND_ASSIGN(SerialConnectionFactory); 48 DISALLOW_COPY_AND_ASSIGN(SerialConnectionFactory);
48 }; 49 };
49 50
50 } // namespace device 51 } // namespace device
51 52
52 #endif // DEVICE_SERIAL_SERIAL_CONNECTION_FACTORY_H_ 53 #endif // DEVICE_SERIAL_SERIAL_CONNECTION_FACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | device/serial/serial_connection_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698