Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: device/serial/serial_service_unittest.cc

Issue 1107013002: [device] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Review Comments : Removal of message_loop_proxy header file Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_service_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "device/serial/serial.mojom.h" 8 #include "device/serial/serial.mojom.h"
9 #include "device/serial/serial_service_impl.h" 9 #include "device/serial/serial_service_impl.h"
10 #include "device/serial/test_serial_io_handler.h" 10 #include "device/serial/test_serial_io_handler.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 void RunConnectTest(const std::string& path, bool expecting_success) { 73 void RunConnectTest(const std::string& path, bool expecting_success) {
74 if (!io_handler_.get()) 74 if (!io_handler_.get())
75 io_handler_ = new TestSerialIoHandler; 75 io_handler_ = new TestSerialIoHandler;
76 mojo::InterfacePtr<serial::SerialService> service; 76 mojo::InterfacePtr<serial::SerialService> service;
77 mojo::BindToProxy( 77 mojo::BindToProxy(
78 new SerialServiceImpl( 78 new SerialServiceImpl(
79 new SerialConnectionFactory( 79 new SerialConnectionFactory(
80 base::Bind(&SerialServiceTest::ReturnIoHandler, 80 base::Bind(&SerialServiceTest::ReturnIoHandler,
81 base::Unretained(this)), 81 base::Unretained(this)),
82 base::MessageLoopProxy::current()), 82 base::ThreadTaskRunnerHandle::Get()),
83 scoped_ptr<SerialDeviceEnumerator>(new FakeSerialDeviceEnumerator)), 83 scoped_ptr<SerialDeviceEnumerator>(new FakeSerialDeviceEnumerator)),
84 &service); 84 &service);
85 mojo::InterfacePtr<serial::Connection> connection; 85 mojo::InterfacePtr<serial::Connection> connection;
86 mojo::InterfacePtr<serial::DataSink> sink; 86 mojo::InterfacePtr<serial::DataSink> sink;
87 mojo::InterfacePtr<serial::DataSource> source; 87 mojo::InterfacePtr<serial::DataSource> source;
88 mojo::InterfacePtr<serial::DataSourceClient> source_client; 88 mojo::InterfacePtr<serial::DataSourceClient> source_client;
89 mojo::GetProxy(&source_client); 89 mojo::GetProxy(&source_client);
90 service->Connect(path, serial::ConnectionOptions::New(), 90 service->Connect(path, serial::ConnectionOptions::New(),
91 mojo::GetProxy(&connection), mojo::GetProxy(&sink), 91 mojo::GetProxy(&connection), mojo::GetProxy(&sink),
92 mojo::GetProxy(&source), source_client.Pass()); 92 mojo::GetProxy(&source), source_client.Pass());
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 TEST_F(SerialServiceTest, ConnectInvalidPath) { 133 TEST_F(SerialServiceTest, ConnectInvalidPath) {
134 RunConnectTest("invalid_path", false); 134 RunConnectTest("invalid_path", false);
135 } 135 }
136 136
137 TEST_F(SerialServiceTest, ConnectOpenFailed) { 137 TEST_F(SerialServiceTest, ConnectOpenFailed) {
138 io_handler_ = new FailToOpenIoHandler; 138 io_handler_ = new FailToOpenIoHandler;
139 RunConnectTest("device", false); 139 RunConnectTest("device", false);
140 } 140 }
141 141
142 } // namespace device 142 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/serial_service_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698