Emulate GL_PRIMITIVE_RESTART_FIXED_INDEX: part I

Emulate GL_PRIMITIVE_RESTART_FIXED_INDEX: part I

Note that this is only partial implementation.

BUG=481184, 480709
TEST=gpu_unittests
R=piman@chromium.org

Committed: https://crrev.com/640dc659d8f125a5fc71c1c1069572b9045de8e7
Cr-Commit-Position: refs/heads/master@{#327202}

[Zhenyao Mo, 2015-04-24 21:40:43]

piman: please take a look. This is a simple attempt to silence the warning
message.

https://codereview.chromium.org/1106833002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/context_state.cc (left):

https://codereview.chromium.org/1106833002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/context_state.cc:295: NOTIMPLEMENTED();
We need to remove this NOTIMPLEMENTED() because it spits out too many lines in
WebGL conformance tests on Linux GPU bot (which is GL 4.1).

This path is hit because we do ES3 states querying on top of ES3 capable
context, not ES3 enabled context, and GL 4.1 is currently considered as ES3
capable.

We are turning on WebGL 2 conformance tests soon, so we need to remove this
warning line anyway.

[Zhenyao Mo, 2015-04-24 21:41:50]

zmo@chromium.org changed reviewers:
+ bajones@chromium.org, kbr@chromium.org

[piman, 2015-04-27 23:05:27]

LGTM+nit, but you have a typo in the CL title (INDED vs INDEX).

https://codereview.chromium.org/1106833002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_state.cc (right):

https://codereview.chromium.org/1106833002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state.cc:287: if (pname ==
GL_PRIMITIVE_RESTART_FIXED_INDEX) {
nit: can you add a TODO linking to the bug?
I understand we're trying to silence the warning, but this is the wrong
behavior, it should be made obvious here.

[Zhenyao Mo, 2015-04-27 23:11:22]

https://codereview.chromium.org/1106833002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_state.cc (right):

https://codereview.chromium.org/1106833002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state.cc:287: if (pname ==
GL_PRIMITIVE_RESTART_FIXED_INDEX) {
On 2015/04/27 23:05:27, piman (Very slow to review) wrote:
> nit: can you add a TODO linking to the bug?
> I understand we're trying to silence the warning, but this is the wrong
> behavior, it should be made obvious here.

So here the behavior is correct.  Nothing to be done further.  But we need to do
more in other places to make this work, i.e., in each draw call, set the index
according to the type using glPrimitiveRestartIndex. I'll add to do to both
DrawArray and DrawElements.

[Zhenyao Mo, 2015-04-27 23:16:15]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2015-04-27 23:16:15]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1106833002/#ps60001
(title: "update comments")

[commit-bot: I haz the power, 2015-04-27 23:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106833002/60001

[commit-bot: I haz the power, 2015-04-28 00:53:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-28 00:54:32]

Patchset 4 (id:??) landed as
https://crrev.com/640dc659d8f125a5fc71c1c1069572b9045de8e7
Cr-Commit-Position: refs/heads/master@{#327202}