Emulate GL_PRIMITIVE_RESTART_FIXED_INDEX: part I

gpu/command_buffer/service/context_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/context_state.h"
 
 #include <cmath>
 
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "gpu/command_buffer/service/buffer_manager.h"
@@ skipping 267 matching lines @@
   RestoreProgramBindings();
   RestoreGlobalState(prev_state);
 }
 
 ErrorState* ContextState::GetErrorState() {
   return error_state_.get();
 }
 
 void ContextState::EnableDisable(GLenum pname, bool enable) const {
   if (pname == GL_PRIMITIVE_RESTART_FIXED_INDEX) {
-    // This is only available on Desktop GL 4.3+, but we emulate ES 3.0 on top
-    // of Desktop GL 4.2+.
-    const gfx::GLVersionInfo& gl_version = feature_info_->gl_version_info();
-    if (!gl_version.is_es &&
-        (gl_version.major_version < 4 ||
-         (gl_version.major_version == 4 && gl_version.minor_version < 3))) {
-      // TODO(zmo): Ignoring it may not be the best emulation.
-      NOTIMPLEMENTED();

[Zhenyao Mo, 2015/04/24 21:40:42]

We need to remove this NOTIMPLEMENTED() because it spits out too many lines in
WebGL conformance tests on Linux GPU bot (which is GL 4.1).

This path is hit because we do ES3 states querying on top of ES3 capable
context, not ES3 enabled context, and GL 4.1 is currently considered as ES3
capable.

We are turning on WebGL 2 conformance tests soon, so we need to remove this
warning line anyway.

-      return;
-    }
+    if (feature_info_->feature_flags().emulate_primitive_restart_fixed_index)
+      pname = GL_PRIMITIVE_RESTART;
   }
   if (enable) {
     glEnable(pname);
   } else {
     glDisable(pname);
   }
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/context_state_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu