Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 110633002: Remove calls to deprecated toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove calls to deprecated toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) Remove calls to deprecated toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) and use the V8TRYCATCH_FOR_V8STRINGRESOURCE*() macros instead so that we return early if an exception is thrown by v8::String::ToString(). R=haraken BUG=327338 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163708

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M Source/bindings/v8/ScriptEventListener.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptValue.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years ago (2013-12-09 20:14:42 UTC) #1
haraken
LGTM
7 years ago (2013-12-10 00:24:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/110633002/1
7 years ago (2013-12-11 03:53:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/bindings/v8/V8Binding.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-11 03:53:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/110633002/20001
7 years ago (2013-12-11 14:22:44 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-11 15:18:06 UTC) #6
Message was sent while issue was closed.
Change committed as 163708

Powered by Google App Engine
This is Rietveld 408576698