Source/bindings/v8/ScriptEventListener.cpp - Issue 110633002: Remove calls to deprecated toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptEventListener.cpp

Issue 110633002: Remove calls to deprecated toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/ScriptEventListener.cpp

diff --git a/Source/bindings/v8/ScriptEventListener.cpp b/Source/bindings/v8/ScriptEventListener.cpp

index a3c258899b1e998a8d9449ed9b0e75bac36e0d7b..0c5c9b57e38c649733930247e747c3d81ff0b4a5 100644

--- a/Source/bindings/v8/ScriptEventListener.cpp

+++ b/Source/bindings/v8/ScriptEventListener.cpp

@@ -107,7 +107,8 @@ String eventListenerHandlerBody(Document* document, EventListener* listener)

if (function.IsEmpty())

return "";

- return toWebCoreStringWithNullCheck(function);

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithNullCheck>, functionString, function, "");

+ return functionString;

}

ScriptValue eventListenerHandler(Document* document, EventListener* listener)

« no previous file with comments | « no previous file | Source/bindings/v8/ScriptValue.cpp » ('j') | no next file with comments »