Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

Issue 110633002: Remove calls to deprecated toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2009 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 if (!populateContextMenuItems(subItemsArray, subMenu, isolate)) 81 if (!populateContextMenuItems(subItemsArray, subMenu, isolate))
82 return false; 82 return false;
83 V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithNullChec k>, labelString, label, false); 83 V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithNullChec k>, labelString, label, false);
84 ContextMenuItem item(SubmenuType, 84 ContextMenuItem item(SubmenuType,
85 ContextMenuItemCustomTagNoAction, 85 ContextMenuItemCustomTagNoAction,
86 labelString, 86 labelString,
87 &subMenu); 87 &subMenu);
88 menu.appendItem(item); 88 menu.appendItem(item);
89 } else { 89 } else {
90 ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMe nuItemBaseCustomTag + id->ToInt32()->Value()); 90 ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMe nuItemBaseCustomTag + id->ToInt32()->Value());
91 ContextMenuItem menuItem((typeString == "checkbox" ? CheckableAction Type : ActionType), typedId, toWebCoreStringWithNullCheck(label)); 91 V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithNullChec k>, labelString, label, false);
92 ContextMenuItem menuItem((typeString == "checkbox" ? CheckableAction Type : ActionType), typedId, labelString);
92 if (checked->IsBoolean()) 93 if (checked->IsBoolean())
93 menuItem.setChecked(checked->ToBoolean()->Value()); 94 menuItem.setChecked(checked->ToBoolean()->Value());
94 if (enabled->IsBoolean()) 95 if (enabled->IsBoolean())
95 menuItem.setEnabled(enabled->ToBoolean()->Value()); 96 menuItem.setEnabled(enabled->ToBoolean()->Value());
96 menu.appendItem(menuItem); 97 menu.appendItem(menuItem);
97 } 98 }
98 } 99 }
99 return true; 100 return true;
100 } 101 }
101 102
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 histogramEnumeration("DevTools.PanelShown", info, 20); 143 histogramEnumeration("DevTools.PanelShown", info, 20);
143 } 144 }
144 145
145 void V8InspectorFrontendHost::recordSettingChangedMethodCustom(const v8::Functio nCallbackInfo<v8::Value>& info) 146 void V8InspectorFrontendHost::recordSettingChangedMethodCustom(const v8::Functio nCallbackInfo<v8::Value>& info)
146 { 147 {
147 histogramEnumeration("DevTools.SettingChanged", info, 100); 148 histogramEnumeration("DevTools.SettingChanged", info, 100);
148 } 149 }
149 150
150 } // namespace WebCore 151 } // namespace WebCore
151 152
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698