chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

index c252dbe147429354258e93a3641f38b255070373..b0a51f9e791ec4bfa5f74023f926e3d22a3f24ec 100644

--- a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

@@ -55,7 +55,7 @@ TEST_F(BookmarkUIUtilsTest, HasBookmarkURLs) {

// folder to create a two level hierarchy.

// But first we have to remove the URL from |folder1|.

- model->Remove(folder1, 0);

+ model->Remove(folder1->GetChild(0));

const BookmarkNode* subfolder1 =

model->AddFolder(folder1, 0, ASCIIToUTF16("Subfolder1"));