Avoid conversion of index to BookmarkNode pointer unnacessarily.

chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/test/test_bookmark_client.h"
@@ skipping 37 matching lines @@
   // This verifies if HasBookmarkURLs iterates through immediate children.
   model->AddURL(folder1, 0, ASCIIToUTF16("Foo"), GURL("http://randomsite.com"));
   EXPECT_TRUE(chrome::HasBookmarkURLs(nodes));
 
   // This verifies that HasBookmarkURLS does not iterate through descendants.
   // i.e, it should not find an URL inside a two or three level hierarchy.
   // So we add another folder to |folder1| and add another page to that new
   // folder to create a two level hierarchy.
 
   // But first we have to remove the URL from |folder1|.
-  model->Remove(folder1, 0);
+  model->Remove(folder1->GetChild(0));
 
   const BookmarkNode* subfolder1 =
       model->AddFolder(folder1, 0, ASCIIToUTF16("Subfolder1"));
 
   // Now add the URL to that |subfolder1|.
   model->AddURL(subfolder1, 0, ASCIIToUTF16("BAR"), GURL("http://bar-foo.com"));
   EXPECT_FALSE(chrome::HasBookmarkURLs(nodes));
 }
 
 TEST_F(BookmarkUIUtilsTest, HasBookmarkURLsAllowedInIncognitoMode) {
@@ skipping 38 matching lines @@
   model->AddURL(folder1, 0, ASCIIToUTF16("Foo"), GURL("http://randomsite.com"));
   EXPECT_TRUE(chrome::HasBookmarkURLsAllowedInIncognitoMode(nodes, &profile));
 
   // This verifies that HasBookmarkURLsAllowedInIncognitoMode does not iterate
   // through descendants.
   // i.e, it should not find an URL inside a two or three level hierarchy.
   // So we add another folder to |folder1| and add another page to that new
   // folder to create a two level hierarchy.
 
   // But first we have to remove the URL from |folder1|.
-  model->Remove(folder1, 0);
+  model->Remove(folder1->GetChild(0));
 
   const BookmarkNode* subfolder1 =
       model->AddFolder(folder1, 0, ASCIIToUTF16("Subfolder1"));
 
   // Now add the URL to that |subfolder1|.
   model->AddURL(subfolder1, 0, ASCIIToUTF16("BAR"), GURL("http://bar-foo.com"));
   EXPECT_FALSE(chrome::HasBookmarkURLsAllowedInIncognitoMode(nodes, &profile));
 }
 
 }  // namespace
 #endif