chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc ('k') | chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc

index 88691b00c4dfbb84ce98904eb101f6331e7e94b9..f1717889c7739e1c31d3912d1abe29fcf193f3f8 100644

--- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc

+++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc

@@ -110,7 +110,7 @@ TEST_F(RecentlyUsedFoldersComboModelTest, NotifyObserver) {

const int initial_count = model.GetItemCount();

// Remove a folder, it should remove an item from the model too.

- GetModel()->Remove(folder, folder->GetIndexOf(sub_folder));

+ GetModel()->Remove(sub_folder);

EXPECT_TRUE(observer.GetAndClearChanged());

const int updated_count = model.GetItemCount();

EXPECT_LT(updated_count, initial_count);