Issue 1105233003: Revert of Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1105233003: Revert of Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM (Closed)

Created:
5 years, 7 months ago by mtklein

Modified:
5 years, 7 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM (patchset #2 id:20001 of https://codereview.chromium.org/1109913002/) Reason for revert: arm64 typos Original issue's description: > Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM > > This is a logical no-op. Everything was using the equivalent of rsqrt1() before, and is now after. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9de16283fdc8cc0d31a84f503578d0ecea4e8297 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9a22f489e8722dd83c65f33fb886019d9f60e479

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -49 lines)			Patch
M	src/core/SkNx.h	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/effects/gradients/SkRadialGradient.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/opts/SkNx_neon.h	View	3 chunks	+20 lines, -27 lines	0 comments	Download
M	src/opts/SkNx_sse.h	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	tests/SkNxTest.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM

5 years, 7 months ago (2015-04-27 20:55:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105233003/1

5 years, 7 months ago (2015-04-27 20:55:46 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-04-27 20:55:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a22f489e8722dd83c65f33fb886019d9f60e479