Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1109913002: Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split rsqrt into rsqrt{0,1,2}, with increasing cost and precision on ARM This is a logical no-op. Everything was using the equivalent of rsqrt1() before, and is now after. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9de16283fdc8cc0d31a84f503578d0ecea4e8297 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot Committed: https://skia.googlesource.com/skia/+/d7c014ff03d44d3ed7a6a2ddca59621a7e98f739

Patch Set 1 #

Patch Set 2 : Use rsqrt1() #

Patch Set 3 : arm64 typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M src/core/SkNx.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 2 3 chunks +27 lines, -20 lines 0 comments Download
M src/opts/SkNx_sse.h View 3 chunks +9 lines, -3 lines 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein_C
5 years, 7 months ago (2015-04-27 19:12:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109913002/20001
5 years, 7 months ago (2015-04-27 19:32:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-27 19:36:16 UTC) #6
reed1
lgtm
5 years, 7 months ago (2015-04-27 20:50:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109913002/20001
5 years, 7 months ago (2015-04-27 20:51:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9de16283fdc8cc0d31a84f503578d0ecea4e8297
5 years, 7 months ago (2015-04-27 20:51:31 UTC) #10
mtklein
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1105233003/ by mtklein@google.com. ...
5 years, 7 months ago (2015-04-27 20:55:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109913002/40001
5 years, 7 months ago (2015-04-27 20:58:34 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:22:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d7c014ff03d44d3ed7a6a2ddca59621a7e98f739

Powered by Google App Engine
This is Rietveld 408576698