Issue 11050009: Use ScopedCOMInitializer in more places. While this doesn't always simplify code, it does mean we …

Issue 11050009: Use ScopedCOMInitializer in more places. While this doesn't always simplify code, it does mean we … (Closed)

Created:
8 years, 2 months ago by Peter Kasting

Modified:
8 years, 2 months ago

Reviewers:
sky, Ryan Sleevi, Scott Byer, brettw, Jamie, grt (UTC plus 2)

CC:
chromium-reviews, amit, yoshiki+watch_chromium.org, dmazzoni+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, wez+watch_chromium.org, browser-components-watch_chromium.org, sanjeevr, yuzo+watch_chromium.org, simonmorris+watch_chromium.org, rmsousa+watch_chromium.org, sergeyu+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, davidbarr+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, robertshield, dtseng+watch_chromium.org, alexeypa+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Use ScopedCOMInitializer in more places. While this doesn't always simplify code, it does mean we do consistent logging and error-checking at all these sites. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159908

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 5

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -151 lines)			Patch
M	base/win/scoped_comptr_unittest.cc	View		2 chunks	+34 lines, -36 lines	0 comments	Download
M	base/win/shortcut_unittest.cc	View		4 chunks	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/history/history_publisher.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/history/history_publisher_win.cc	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/installer/setup/setup_main.cc	View		3 chunks	+3 lines, -22 lines	0 comments	Download
M	chrome/installer/util/run_all_unittests.cc	View		2 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View		7 chunks	+9 lines, -13 lines	0 comments	Download
M	chrome_frame/test/reliability/reliability_test_suite.h	View		2 chunks	+9 lines, -5 lines	2 comments	Download
M	chrome_frame/update_launcher.cc	View	1 2	3 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/utils.h	View		2 chunks	+11 lines, -5 lines	2 comments	Download
M	content/browser/accessibility/browser_accessibility_win_unittest.cc	View	1 2 3	2 chunks	+8 lines, -5 lines	0 comments	Download
M	content/browser/accessibility/cross_platform_accessibility_browsertest.cc	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	content/browser/browser_process_sub_thread.h	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	content/browser/browser_process_sub_thread.cc	View	1	4 chunks	+6 lines, -9 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		5 chunks	+9 lines, -7 lines	0 comments	Download
M	content/plugin/plugin_main.cc	View		4 chunks	+3 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View		3 chunks	+2 lines, -2 lines	1 comment	Download
M	remoting/host/setup/daemon_controller_win.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	ui/base/dialogs/base_shell_dialog_win.cc	View		3 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

brettw: base/, chrome/browser/history/, content/ sky: chrome/browser/ui/views/accessibility/, ui/base/dialogs/ grt: chrome/installer/, chrome_frame/ scottbyer: chrome/service/cloudprint/ rsleevi: net/url_request/ jamiewalch: ...

8 years, 2 months ago (2012-10-03 01:24:49 UTC) #1

Ryan Sleevi

LGTM, mod naming nit https://codereview.chromium.org/11050009/diff/13005/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/11050009/diff/13005/net/url_request/url_request_unittest.cc#newcode706 net/url_request/url_request_unittest.cc:706: base::win::ScopedCOMInitializer com_initializer_; nit: naming

8 years, 2 months ago (2012-10-03 12:50:42 UTC) #4

grt (UTC plus 2)

chrome/installer and chrome_frame lgtm w/ some nits. https://codereview.chromium.org/11050009/diff/13005/chrome_frame/test/reliability/reliability_test_suite.h File chrome_frame/test/reliability/reliability_test_suite.h (right): https://codereview.chromium.org/11050009/diff/13005/chrome_frame/test/reliability/reliability_test_suite.h#newcode18 chrome_frame/test/reliability/reliability_test_suite.h:18: virtual void ...

8 years, 2 months ago (2012-10-03 13:37:27 UTC) #5

Scott Byer

8 years, 2 months ago (2012-10-03 16:05:42 UTC) #7

chrome/service/cloud_print LGTM


On 2012/10/03 01:24:49, Peter Kasting wrote:
> brettw: base/, chrome/browser/history/, content/
> sky: chrome/browser/ui/views/accessibility/, ui/base/dialogs/
> grt: chrome/installer/, chrome_frame/
> scottbyer: chrome/service/cloudprint/
> rsleevi: net/url_request/
> jamiewalch: remoting/host/setup/

Expand Messages | Collapse Messages