Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: base/win/shortcut_unittest.cc

Issue 11050009: Use ScopedCOMInitializer in more places. While this doesn't always simplify code, it does mean we … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/win/shortcut_unittest.cc
===================================================================
--- base/win/shortcut_unittest.cc (revision 159813)
+++ base/win/shortcut_unittest.cc (working copy)
@@ -4,9 +4,6 @@
#include "base/win/shortcut.h"
-#include <windows.h>
-#include <objbase.h>
-
#include <string>
#include "base/file_path.h"
@@ -14,6 +11,7 @@
#include "base/scoped_temp_dir.h"
#include "base/test/test_file_util.h"
#include "base/test/test_shortcut_win.h"
+#include "base/win/scoped_com_initializer.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -27,8 +25,6 @@
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
ASSERT_TRUE(temp_dir_2_.CreateUniqueTempDir());
- EXPECT_EQ(S_OK, CoInitialize(NULL));
-
link_file_ = temp_dir_.path().Append(L"My Link.lnk");
// Shortcut 1's properties
@@ -65,10 +61,7 @@
}
}
- virtual void TearDown() OVERRIDE {
- CoUninitialize();
- }
-
+ base::win::ScopedCOMInitializer com_initializer_;
ScopedTempDir temp_dir_;
ScopedTempDir temp_dir_2_;

Powered by Google App Engine
This is Rietveld 408576698