Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1104813005: [Extensions Toolbar] Refactor a few test classes (Closed)

Created:
5 years, 8 months ago by Devlin
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar] Refactor a few test classes Pull the implementation of TestToolbarActionsBarHelper into BrowserActionTestUtil. The former is really only ever used with the latter, and this allows: - Tests to only worry about one test object. - For one top-level fewer platform-specific test class. TBR=sky@chromium.org (something wonky in our OWNERs check isn't counting Finnur/me as owners for toolbar actions stuff...) Committed: https://crrev.com/0c1c08b20cec291b23f1ee04018886ba70d67008 Cr-Commit-Position: refs/heads/master@{#327134}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -289 lines) Patch
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 21 chunks +50 lines, -43 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_action_test_util.h View 1 2 4 chunks +27 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm View 1 2 9 chunks +93 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/test_toolbar_actions_bar_helper_cocoa.mm View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/ui/toolbar/test_toolbar_actions_bar_helper.h View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc View 4 chunks +7 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 1 2 5 chunks +97 lines, -21 lines 0 comments Download
D chrome/browser/ui/views/toolbar/test_toolbar_actions_bar_helper_views.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Devlin
Mind taking a look? Just shifting code in this one (needed it for the next ...
5 years, 8 months ago (2015-04-24 23:50:47 UTC) #6
Finnur
LGTM
5 years, 8 months ago (2015-04-27 13:42:08 UTC) #7
Devlin
Avi, mind taking a quick look at the Cocoa? Just code movement, but a little ...
5 years, 8 months ago (2015-04-27 18:30:22 UTC) #10
Avi (use Gerrit)
lgtm stampity stamp
5 years, 8 months ago (2015-04-27 18:35:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104813005/160001
5 years, 8 months ago (2015-04-27 20:13:33 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59324)
5 years, 8 months ago (2015-04-27 20:22:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104813005/160001
5 years, 8 months ago (2015-04-27 21:07:52 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:160001)
5 years, 8 months ago (2015-04-27 21:35:37 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:37:05 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c1c08b20cec291b23f1ee04018886ba70d67008
Cr-Commit-Position: refs/heads/master@{#327134}

Powered by Google App Engine
This is Rietveld 408576698