Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: chrome/browser/extensions/extension_keybinding_apitest.cc

Issue 1104813005: [Extensions Toolbar] Refactor a few test classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_keybinding_apitest.cc
diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc
index a58db86d65061f60230fa67474d375cf673d3535..6985b547e1881d4e16fa030b5b0d3ee07e33cdad 100644
--- a/chrome/browser/extensions/extension_keybinding_apitest.cc
+++ b/chrome/browser/extensions/extension_keybinding_apitest.cc
@@ -133,10 +133,6 @@ class CommandsApiTest : public ExtensionApiTest {
~CommandsApiTest() override {}
protected:
- BrowserActionTestUtil GetBrowserActionsBar() {
- return BrowserActionTestUtil(browser());
- }
-
bool IsGrantedForTab(const Extension* extension,
const content::WebContents* web_contents) {
return extension->permissions_data()->HasAPIPermissionForTab(
@@ -187,8 +183,9 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, Basic) {
// immaterial to this test).
ASSERT_TRUE(RunExtensionTest("keybinding/conflicting")) << message_;
+ BrowserActionTestUtil browser_actions_bar(browser());
// Test that there are two browser actions in the toolbar.
- ASSERT_EQ(2, GetBrowserActionsBar().NumberOfBrowserActions());
+ ASSERT_EQ(2, browser_actions_bar.NumberOfBrowserActions());
ui_test_utils::NavigateToURL(
browser(), test_server()->GetURL("files/extensions/test_file.txt"));

Powered by Google App Engine
This is Rietveld 408576698