Issue 11048015: Merge 129775 - Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11048015: Merge 129775 - Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar … (Closed)

Created:
8 years, 2 months ago by vsevik

Modified:
8 years, 2 months ago

Reviewers:
vsevik

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/

Visibility:
Public.

More Reviews

Description

Merge 129775 - Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane. https://bugs.webkit.org/show_bug.cgi?id=97783 Reviewed by Pavel Feldman. BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation. * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._filteredBreakpointLocations): (WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode): (WebInspector.BreakpointManager.prototype.allBreakpointLocations): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded): TBR=vsevik@chromium.org BUG=152684 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130258

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -4 lines)			Patch
	M	Source/WebCore/inspector/front-end/BreakpointManager.js	View		2 chunks	+26 lines, -4 lines	0 comments	Download
	M	Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages