Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js

Issue 11048015: Merge 129775 - Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar … (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/inspector/front-end/BreakpointManager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js
===================================================================
--- Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js (revision 130257)
+++ Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js (working copy)
@@ -45,6 +45,11 @@
this.bodyElement.appendChild(this.emptyElement);
this._items = new Map();
+
+ var breakpointLocations = this._breakpointManager.allBreakpointLocations();
+ for (var i = 0; i < breakpointLocations.length; ++i)
+ this._addBreakpoint(breakpointLocations[i].breakpoint, breakpointLocations[i].uiLocation);
+
this._breakpointManager.addEventListener(WebInspector.BreakpointManager.Events.BreakpointAdded, this._breakpointAdded, this);
this._breakpointManager.addEventListener(WebInspector.BreakpointManager.Events.BreakpointRemoved, this._breakpointRemoved, this);
}
@@ -59,7 +64,15 @@
var breakpoint = /** @type {WebInspector.BreakpointManager.Breakpoint} */ event.data.breakpoint;
var uiLocation = /** @type {WebInspector.UILocation} */ event.data.uiLocation;
+ this._addBreakpoint(breakpoint, uiLocation);
+ },
+ /**
+ * @param {WebInspector.BreakpointManager.Breakpoint} breakpoint
+ * @param {WebInspector.UILocation} uiLocation
+ */
+ _addBreakpoint: function(breakpoint, uiLocation)
+ {
var element = document.createElement("li");
element.addStyleClass("cursor-pointer");
element.addEventListener("contextmenu", this._breakpointContextMenu.bind(this, breakpoint), true);
« no previous file with comments | « Source/WebCore/inspector/front-end/BreakpointManager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698