Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11047013: Minor fixes to test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 49868d7b3657fab32724325f67e14cea61621cbe..caa9ee102d6861834d0f0849c0dc101ac7be734e 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -206,10 +206,19 @@ class BrowserTestCase extends TestCase {
* the time the process took to run. It also contains a pointer to the
* [TestCase] this is the output of.
*/
-interface TestOutput default TestOutputImpl {
- TestOutput.fromCase(TestCase testCase, int exitCode, bool incomplete,
- bool timedOut,
- List<String> stdout, List<String> stderr, Duration time);
+abstract class TestOutput {
+ factory TestOutput.fromCase(TestCase testCase,
+ int exitCode,
+ bool incomplete,
+ bool timedOut,
+ List<String> stdout,
+ List<String> stderr,
+ Duration time) {
+ return new TestOutputImpl.fromCase(
+ testCase, exitCode, incomplete, timedOut, stdout, stderr, time);
+ }
+
+ bool get incomplete;
String get result;
@@ -272,14 +281,13 @@ class TestOutputImpl implements TestOutput {
testCase.output = this;
diagnostics = [];
}
-
- factory TestOutputImpl.fromCase (TestCase testCase,
- int exitCode,
- bool incomplete,
- bool timedOut,
- List<String> stdout,
- List<String> stderr,
- Duration time) {
+ factory TestOutputImpl.fromCase(TestCase testCase,
+ int exitCode,
+ bool incomplete,
+ bool timedOut,
+ List<String> stdout,
+ List<String> stderr,
+ Duration time) {
if (testCase is BrowserTestCase) {
return new BrowserTestOutputImpl(testCase, exitCode, incomplete,
timedOut, stdout, stderr, time);
@@ -364,6 +372,7 @@ class BrowserTestOutputImpl extends TestOutputImpl {
if (has_content_type) {
return (exitCode != 0 && !hasCrashed);
}
+ break;
}
}
return true;

Powered by Google App Engine
This is Rietveld 408576698