Minor fixes to test.dart.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 188 matching lines @@
       _lastArguments.getRange(1, _lastArguments.length - 1);
 }
 
 
 /**
  * TestOutput records the output of a completed test: the process's exit code,
  * the standard output and standard error, whether the process timed out, and
  * the time the process took to run.  It also contains a pointer to the
  * [TestCase] this is the output of.
  */
-interface TestOutput default TestOutputImpl {
-  TestOutput.fromCase(TestCase testCase, int exitCode, bool incomplete,
-                      bool timedOut,
-                      List<String> stdout, List<String> stderr, Duration time);
+abstract class TestOutput {
+  factory TestOutput.fromCase(TestCase testCase,
+                              int exitCode,
+                              bool incomplete,
+                              bool timedOut,
+                              List<String> stdout,
+                              List<String> stderr,
+                              Duration time) {
+    return new TestOutputImpl.fromCase(
+        testCase, exitCode, incomplete, timedOut, stdout, stderr, time);
+  }
+
+  bool get incomplete;
 
   String get result;
 
   bool get unexpectedOutput;
 
   bool get hasCrashed;
 
   bool get hasTimedOut;
 
   bool get didFail;
@@ skipping 42 matching lines @@
   TestOutputImpl(TestCase this.testCase,
                  int this.exitCode,
                  bool this.incomplete,
                  bool this.timedOut,
                  List<String> this.stdout,
                  List<String> this.stderr,
                  Duration this.time) {
     testCase.output = this;
     diagnostics = [];
   }
-
-  factory TestOutputImpl.fromCase (TestCase testCase,
-                                   int exitCode,
-                                   bool incomplete,
-                                   bool timedOut,
-                                   List<String> stdout,
-                                   List<String> stderr,
-                                   Duration time) {
+  factory TestOutputImpl.fromCase(TestCase testCase,
+                                  int exitCode,
+                                  bool incomplete,
+                                  bool timedOut,
+                                  List<String> stdout,
+                                  List<String> stderr,
+                                  Duration time) {
     if (testCase is BrowserTestCase) {
       return new BrowserTestOutputImpl(testCase, exitCode, incomplete,
           timedOut, stdout, stderr, time);
     } else if (testCase.configuration['compiler'] == 'dartc') {
       return new AnalysisTestOutputImpl(testCase, exitCode, timedOut,
           stdout, stderr, time);
     }
     return new TestOutputImpl(testCase, exitCode, incomplete, timedOut,
         stdout, stderr, time);
   }
@@ skipping 64 matching lines @@
     for (String line in super.stdout) {
       switch (line) {
         case 'Content-Type: text/plain':
           has_content_type = true;
           break;
 
         case 'PASS':
           if (has_content_type) {
             return (exitCode != 0 && !hasCrashed);
           }
+          break;
       }
     }
     return true;
   }
 }
 
 // The static analyzer does not actually execute code, so
 // the criteria for success now depend on the text sent
 // to stderr.
 class AnalysisTestOutputImpl extends TestOutputImpl {
@@ skipping 850 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }