Chromium Code Reviews| Index: tools/testing/dart/test_suite.dart |
| diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart |
| index 795f242297c9b00c8578688c5341cd2937eec921..b2f25ee741b3424e3b03e78c8fd39f14c600fd41 100644 |
| --- a/tools/testing/dart/test_suite.dart |
| +++ b/tools/testing/dart/test_suite.dart |
| @@ -46,7 +46,7 @@ typedef void VoidFunction(); |
| * Most TestSuites represent a directory or directory tree containing tests, |
| * and a status file containing the expected results when these tests are run. |
| */ |
| -interface TestSuite { |
| +abstract class TestSuite { |
| /** |
| * Call the callback function onTest with a [TestCase] argument for each |
| * test in the suite. When all tests have been processed, call [onDone]. |
| @@ -832,8 +832,6 @@ class StandardTestSuite implements TestSuite { |
| bool get hasRuntime { |
| switch(configuration['runtime']) { |
| - case null: |
| - Expect.fail("configuration['runtime'] is not set"); |
|
ricow1
2012/10/03 10:39:03
if we don't pass runtime in on the command line do
Mads Ager (google)
2012/10/03 10:44:10
At this point I'm just cleaning this up. 'runtime'
|
| case 'none': |
| return false; |
| default: |
| @@ -1335,6 +1333,7 @@ class TestUtils { |
| } else { |
| return '${prefix}dart2js$suffix'; |
| } |
| + break; |
| default: |
| throw "Unknown executable for: ${configuration['compiler']}"; |
| } |