Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1104243003: Oilpan: put ClientRect(List) on the heap. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: put ClientRect(List) on the heap. R=kouhei BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194550

Patch Set 1 #

Patch Set 2 : Remove transition types uses also #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -65 lines) Patch
M Source/core/dom/ClientRect.h View 1 chunk +7 lines, -9 lines 0 comments Download
M Source/core/dom/ClientRect.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRectList.h View 2 chunks +8 lines, -12 lines 0 comments Download
M Source/core/dom/ClientRectList.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ClientRectList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTRegion.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHighlight.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 7 chunks +10 lines, -10 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 8 chunks +10 lines, -10 lines 0 comments Download
M Source/core/testing/LayerRect.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/LayerRectList.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/LayerRectList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-27 20:16:42 UTC) #2
kouhei (in TOK)
lgtm
5 years, 8 months ago (2015-04-27 21:33:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104243003/20001
5 years, 8 months ago (2015-04-27 21:36:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194550
5 years, 8 months ago (2015-04-27 21:40:53 UTC) #9
haraken
5 years, 8 months ago (2015-04-28 00:51:45 UTC) #11
Message was sent while issue was closed. 
LGTM

https://codereview.chromium.org/1104243003/diff/20001/Source/web/tests/TouchA...
File Source/web/tests/TouchActionTest.cpp (right):

https://codereview.chromium.org/1104243003/diff/20001/Source/web/tests/TouchA...
Source/web/tests/TouchActionTest.cpp:222: Persistent<ClientRectList> rects =
element->getClientRects();

As dcheng pointed out somewhere, if this really needs to be a Persistent
(instead of a raw pointer) for some reason, let's have a comment on this.

Powered by Google App Engine
This is Rietveld 408576698