Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: Source/web/tests/TouchActionTest.cpp

Issue 1104243003: Oilpan: put ClientRect(List) on the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove transition types uses also Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/LayerRectList.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/TouchActionTest.cpp
diff --git a/Source/web/tests/TouchActionTest.cpp b/Source/web/tests/TouchActionTest.cpp
index 27b76d026b06351fe25df366038e2e4109f1ca2d..a7d15ccb36be0fd4c8d05c3f9a7b1583e5406d1f 100644
--- a/Source/web/tests/TouchActionTest.cpp
+++ b/Source/web/tests/TouchActionTest.cpp
@@ -219,9 +219,9 @@ void TouchActionTest::runTestOnTree(ContainerNode* root, WebView* webView, Touch
// Note that we don't want the bounding box because our tests sometimes have elements with
// multiple border boxes with other elements in between. Use the first border box (which
// we can easily visualize in a browser for debugging).
- RefPtrWillBePersistent<ClientRectList> rects = element->getClientRects();
+ Persistent<ClientRectList> rects = element->getClientRects();
haraken 2015/04/28 00:51:45 As dcheng pointed out somewhere, if this really ne
ASSERT_GE(rects->length(), 0u) << failureContext;
- RefPtrWillBePersistent<ClientRect> r = rects->item(0);
+ Persistent<ClientRect> r = rects->item(0);
FloatRect clientFloatRect = FloatRect(r->left(), r->top(), r->width(), r->height());
IntRect clientRect = enclosedIntRect(clientFloatRect);
for (int locIdx = 0; locIdx < 3; locIdx++) {
« no previous file with comments | « Source/core/testing/LayerRectList.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698