Source/core/html/shadow/MediaControls.cpp - Issue 1104243003: Oilpan: put ClientRect(List) on the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 1104243003: Oilpan: put ClientRect(List) on the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove transition types uses also Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index b0560f11dddbc156a7e77c71ccca1c75b39140a6..486168595d42c6d667301a7cbc196bcee9f41b1f 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -356,7 +356,7 @@ void MediaControls::refreshClosedCaptionsButtonVisibility()

static Element* elementFromCenter(Element& element)

{

- RefPtrWillBeRawPtr<ClientRect> clientRect = element.getBoundingClientRect();

+ ClientRect* clientRect = element.getBoundingClientRect();

int centerX = static_cast<int>((clientRect->left() + clientRect->right()) / 2);

int centerY = static_cast<int>((clientRect->top() + clientRect->bottom()) / 2);