Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1104183004: De-proc Color32 (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

De-proc Color32 Also strips SK_SUPPORT_LEGACY_COLOR32_MATH, which is no longer needed. Seems handy to have SkTypes include the relevant intrinsics when we know we've got them, but I'm not married to it. Locally this looks like a pointlessly small perf win, but I'm mostly keen to get all the code together. BUG=skia: Committed: https://skia.googlesource.com/skia/+/376e9bc206b69d9190f38dfebb132a8769bbd72b Committed: https://skia.googlesource.com/skia/+/d65dc0cedd5b50dd407b6ff8fdc39123f11511cc CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Mips-Debug-Android-Trybot Committed: https://skia.googlesource.com/skia/+/95cc012ccaea20f372893ae277ea0a8a6339d094

Patch Set 1 #

Patch Set 2 : extract common invA setup #

Patch Set 3 : unused declarations #

Patch Set 4 : simplify invA assert #

Patch Set 5 : fix typo #

Patch Set 6 : duh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -203 lines) Patch
M include/core/SkBlitRow.h View 2 chunks +0 lines, -9 lines 0 comments Download
M include/core/SkTypes.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 1 2 3 4 5 2 chunks +84 lines, -21 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 7 chunks +6 lines, -7 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkBlitRow_opts_none.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104183004/1
5 years, 7 months ago (2015-04-27 20:07:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104183004/40001
5 years, 7 months ago (2015-04-27 20:33:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-27 20:39:14 UTC) #6
mtklein_C
5 years, 7 months ago (2015-04-27 20:44:05 UTC) #8
reed1
woot! lgtm
5 years, 7 months ago (2015-04-27 20:53:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104183004/60001
5 years, 7 months ago (2015-04-27 20:55:17 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/376e9bc206b69d9190f38dfebb132a8769bbd72b
5 years, 7 months ago (2015-04-27 21:14:21 UTC) #13
mtklein
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1108163002/ by mtklein@google.com. ...
5 years, 7 months ago (2015-04-27 21:16:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104183004/80001
5 years, 7 months ago (2015-04-27 21:24:21 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/d65dc0cedd5b50dd407b6ff8fdc39123f11511cc
5 years, 7 months ago (2015-04-27 21:47:26 UTC) #18
mtklein
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1102363006/ by mtklein@google.com. ...
5 years, 7 months ago (2015-04-27 21:50:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104183004/100001
5 years, 7 months ago (2015-04-27 21:52:57 UTC) #22
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 22:11:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/95cc012ccaea20f372893ae277ea0a8a6339d094

Powered by Google App Engine
This is Rietveld 408576698