Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1103903003: Clean up Throbber. (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up Throbber. - TimeTicks in place of Time - remove unnecessary member var running_ - etc. BUG=none Committed: https://crrev.com/023c8cd8f05a9162b53cfb3e15253e08fb598781 Cr-Commit-Position: refs/heads/master@{#327073}

Patch Set 1 #

Patch Set 2 : fix spaces #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -46 lines) Patch
M ui/views/controls/throbber.h View 1 1 chunk +3 lines, -7 lines 1 comment Download
M ui/views/controls/throbber.cc View 8 chunks +23 lines, -39 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
5 years, 8 months ago (2015-04-24 23:05:22 UTC) #2
tfarina
https://codereview.chromium.org/1103903003/diff/20001/ui/views/controls/throbber.cc File ui/views/controls/throbber.cc (left): https://codereview.chromium.org/1103903003/diff/20001/ui/views/controls/throbber.cc#oldcode14 ui/views/controls/throbber.cc:14: using base::Time; Would you mind keep the using declarations? ...
5 years, 8 months ago (2015-04-24 23:08:19 UTC) #3
Evan Stade
https://codereview.chromium.org/1103903003/diff/20001/ui/views/controls/throbber.cc File ui/views/controls/throbber.cc (left): https://codereview.chromium.org/1103903003/diff/20001/ui/views/controls/throbber.cc#oldcode14 ui/views/controls/throbber.cc:14: using base::Time; On 2015/04/24 23:08:19, tfarina wrote: > Would ...
5 years, 8 months ago (2015-04-24 23:15:32 UTC) #4
sky
LGTM https://codereview.chromium.org/1103903003/diff/20001/ui/views/controls/throbber.h File ui/views/controls/throbber.h (right): https://codereview.chromium.org/1103903003/diff/20001/ui/views/controls/throbber.h#newcode22 ui/views/controls/throbber.h:22: class VIEWS_EXPORT Throbber : public View { If ...
5 years, 8 months ago (2015-04-27 15:15:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103903003/20001
5 years, 8 months ago (2015-04-27 17:25:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 18:14:45 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:15:28 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/023c8cd8f05a9162b53cfb3e15253e08fb598781
Cr-Commit-Position: refs/heads/master@{#327073}

Powered by Google App Engine
This is Rietveld 408576698