Clean up Throbber.

ui/views/controls/throbber.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_THROBBER_H_
 #define UI_VIEWS_CONTROLS_THROBBER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "ui/views/view.h"
 
 namespace gfx {
 class ImageSkia;
 }
 
 namespace views {
 
 // Throbbers display an animation, usually used as a status indicator.
 
 class VIEWS_EXPORT Throbber : public View {

[sky, 2015/04/27 15:15:07]

If you want more to cleanup this class should really on have the timer running
while visible, and stop the timer when hiden.

  public:
   // |frame_time_ms| is the amount of time that should elapse between frames
   //                 (in milliseconds)
   // If |paint_while_stopped| is false, this view will be invisible when not
   // running.
   Throbber(int frame_time_ms, bool paint_while_stopped);
   Throbber(int frame_time_ms, bool paint_while_stopped, gfx::ImageSkia* frames);
   ~Throbber() override;
 
   // Start and stop the throbber animation
   virtual void Start();
   virtual void Stop();
 
   // Set custom throbber frames. Otherwise IDR_THROBBER is loaded.
   void SetFrames(const gfx::ImageSkia* frames);
 
   // Overridden from View:
   gfx::Size GetPreferredSize() const override;
   void OnPaint(gfx::Canvas* canvas) override;
 
  protected:
-  bool running() const { return running_; }
-  base::Time start_time() const { return start_time_; }
-
   // Specifies whether the throbber is currently animating or not
+  bool IsRunning() const;
+  base::TimeTicks start_time() const { return start_time_; }
 
  private:
-  void Run();
-
-  bool running_;
   bool paint_while_stopped_;
   int frame_count_;  // How many frames we have.
-  base::Time start_time_;  // Time when Start was called.
+  base::TimeTicks start_time_;  // Time when Start was called.
   const gfx::ImageSkia* frames_;  // Frames images.
   base::TimeDelta frame_time_;  // How long one frame is displayed.
   base::RepeatingTimer<Throbber> timer_;  // Used to schedule Run calls.
 
   DISALLOW_COPY_AND_ASSIGN(Throbber);
 };
 
 // A SmoothedThrobber is a throbber that is representing potentially short
 // and nonoverlapping bursts of work.  SmoothedThrobber ignores small
 // pauses in the work stops and starts, and only starts its throbber after
@@ skipping 60 matching lines @@
 
   // The checkmark image. Will be null until it's used (if ever).
   const gfx::ImageSkia* checkmark_;
 
   DISALLOW_COPY_AND_ASSIGN(MaterialThrobber);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_THROBBER_H_