Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Issue 1103553002: Reland Reenable unused-import lint check for telemetry. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, tfarina, yurys, telemetry-reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Reenable unused-import lint check for telemetry. patch from issue 1051323006 at patchset 40001 (http://crrev.com/1051323006#ps40001) BUG=475714 Committed: https://crrev.com/c78f00838a4db55c89521b1606e26f134be8b0be Cr-Commit-Position: refs/heads/master@{#327340}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -107 lines) Patch
M tools/telemetry/pylintrc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/_bitmap.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/android_app_unittest.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/android_app_backend.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/android_command_line_backend_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_http_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend_unittest.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/device_finder.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 3 chunks +4 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_interface.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/trace_profiler_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/tracing_controller_backend.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/image_processing/histogram_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/image_processing/image_util_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/mouse_click_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/action_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/results/user_story_run_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/trace_data.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/trace_data_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/util/file_handle.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/util/file_handle_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/trace.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/trace_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/layout.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nednguyen
+Mef: I would want to understand how the Linux Tests bot running telemetry_unittest. The CQ ...
5 years, 8 months ago (2015-04-22 18:35:43 UTC) #2
dtu
On 2015/04/22 18:35:43, nednguyen wrote: > +Mef: I would want to understand how the Linux ...
5 years, 8 months ago (2015-04-23 00:07:30 UTC) #3
mef
On 2015/04/22 18:35:43, nednguyen wrote: > +Mef: I would want to understand how the Linux ...
5 years, 8 months ago (2015-04-23 15:02:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103553002/20001
5 years, 7 months ago (2015-04-28 17:35:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 18:52:27 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 18:53:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c78f00838a4db55c89521b1606e26f134be8b0be
Cr-Commit-Position: refs/heads/master@{#327340}

Powered by Google App Engine
This is Rietveld 408576698