tools/telemetry/telemetry/core/platform/android_device_unittest.py - Issue 1103553002: Reland Reenable unused-import lint check for telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/android_device_unittest.py

Issue 1103553002: Reland Reenable unused-import lint check for telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/device_finder.py ('k') | tools/telemetry/telemetry/core/platform/android_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/android_device_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/android_device_unittest.py b/tools/telemetry/telemetry/core/platform/android_device_unittest.py

index 6e7609b33713c142e141245e2edf01dd7f4577f0..b8a61dd7195aa7b0060420dafdd8f4c854ec42c8 100644

--- a/tools/telemetry/telemetry/core/platform/android_device_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/android_device_unittest.py

@@ -4,7 +4,6 @@

import unittest

-from telemetry import benchmark

from telemetry.core import browser_options

from telemetry.core.platform import android_device

from telemetry.core.platform import android_platform_backend

@@ -43,7 +42,7 @@ class GetDeviceTest(unittest.TestCase):

def testNoAdbReturnsNone(self):

finder_options = browser_options.BrowserFinderOptions()

- def NoAdb(*_, **__):

+ def NoAdb(*_1, **_2):

raise OSError('not found')

self._android_device_stub.subprocess.Popen = NoAdb