tools/telemetry/telemetry/page/shared_page_state.py - Issue 1103553002: Reland Reenable unused-import lint check for telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 1103553002: Reland Reenable unused-import lint check for telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/page_set_unittest.py ('k') | tools/telemetry/telemetry/page/shared_page_state_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 852247b1f5935db6d695dcc151fa733f72033cc5..fbbe66e8c0a2422674aa15166e71f9ce52e135f4 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -19,7 +19,6 @@ from telemetry.util import exception_formatter

from telemetry.util import file_handle

from telemetry.value import skip

from telemetry.web_perf import timeline_based_measurement

-from telemetry.web_perf import timeline_based_page_test

def _PrepareFinderOptions(finder_options, test, device_type):

@@ -40,6 +39,8 @@ class SharedPageState(shared_user_story_state.SharedUserStoryState):

def __init__(self, test, finder_options, user_story_set):

super(SharedPageState, self).__init__(test, finder_options, user_story_set)

if isinstance(test, timeline_based_measurement.TimelineBasedMeasurement):

+ # This is to avoid the cyclic-import caused by timeline_based_page_test.

+ from telemetry.web_perf import timeline_based_page_test

self._test = timeline_based_page_test.TimelineBasedPageTest(test)

else:

self._test = test