Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1101673005: Extract functions from path recipe module so that step can depend on it (Closed)

Created:
5 years, 8 months ago by Paweł Hajdan Jr.
Modified:
5 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Extract functions from path recipe module so that step can depend on it This will be needed to run recipes on swarming - step will default cwd to slave_build path. BUG=437264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -355 lines) Patch
M scripts/slave/recipe_modules/android/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/android/api.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/archive/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/file/__init__.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/file/api.py View 1 chunk +91 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/file/example.py View 4 chunks +20 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/file/example.expected/file_io.json View 1 chunk +69 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/file/test_api.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/git_clone_bundler/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/git_clone_bundler/api.py View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/path/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/path/api.py View 1 chunk +0 lines, -92 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.py View 1 chunk +0 lines, -16 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/linux.json View 1 chunk +0 lines, -69 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/mac.json View 1 chunk +0 lines, -69 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/win.json View 1 chunk +0 lines, -69 lines 0 comments Download
M scripts/slave/recipe_modules/path/test_api.py View 1 chunk +0 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/pgo/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/pgo/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/skia/api.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/skia/default_flavor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/example.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/syzygy/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/zip/example.py View 3 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_android_trybot.py View 3 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/boringssl.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_codesearch.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/codesearch.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/crashpad/continuous.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/infra/publish_tarball.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/perf/telemetry_generate_large_profile.py View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/perf/telemetry_harness_upload.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/infra.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
5 years, 8 months ago (2015-04-25 01:37:30 UTC) #2
iannucci
lgtm :) Thanks for dropping the dependencies from the path module!
5 years, 8 months ago (2015-04-25 01:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101673005/1
5 years, 8 months ago (2015-04-25 01:49:29 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 01:53:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294996

Powered by Google App Engine
This is Rietveld 408576698