scripts/slave/recipes/perf/telemetry_generate_large_profile.py - Issue 1101673005: Extract functions from path recipe module so that step can depend on it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/perf/telemetry_generate_large_profile.py

Issue 1101673005: Extract functions from path recipe module so that step can depend on it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/perf/telemetry_generate_large_profile.py

diff --git a/scripts/slave/recipes/perf/telemetry_generate_large_profile.py b/scripts/slave/recipes/perf/telemetry_generate_large_profile.py

index b94d2351235a9bef4e06e23083478cd379cb484c..49dc2690afc83a1e2067c8f7c4d4f0251373f1b6 100644

--- a/scripts/slave/recipes/perf/telemetry_generate_large_profile.py

+++ b/scripts/slave/recipes/perf/telemetry_generate_large_profile.py

@@ -6,6 +6,7 @@ DEPS = [

'archive',

'bot_update',

'chromium',

+ 'file',

'gsutil',

'path',

'platform',

@@ -89,8 +90,8 @@ def GenSteps(api):

cloud_file = _CloudStoragePath(api)

api.gsutil.upload(str(zipped_profile_path), bucket, cloud_file)

finally:

- api.path.rmtree('Remove profile directory.', profile_directory)

- api.path.rmtree('Remove zipped profile directory.',

+ api.file.rmtree('Remove profile directory.', profile_directory)

+ api.file.rmtree('Remove zipped profile directory.',

zipped_profile_directory)

« no previous file with comments | « scripts/slave/recipes/infra/publish_tarball.py ('k') | scripts/slave/recipes/perf/telemetry_harness_upload.py » ('j') | no next file with comments »