scripts/slave/recipe_modules/skia/api.py - Issue 1101673005: Extract functions from path recipe module so that step can depend on it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/skia/api.py

Issue 1101673005: Extract functions from path recipe module so that step can depend on it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/skia/api.py

diff --git a/scripts/slave/recipe_modules/skia/api.py b/scripts/slave/recipe_modules/skia/api.py

index f0c90836322fdb6c24b9fba88eb91971d0269b69..0d7b9d00d4621b431642b10a153eb7acb23bfb0b 100644

--- a/scripts/slave/recipe_modules/skia/api.py

+++ b/scripts/slave/recipe_modules/skia/api.py

@@ -220,7 +220,7 @@ class SkiaApi(recipe_api.RecipeApi):

def download_and_copy_images(self):

"""Download test images if needed."""

# Ensure that the tmp_dir exists.

- self._run_once(self.m.path.makedirs, 'tmp_dir', self.tmp_dir)

+ self._run_once(self.m.file.makedirs, 'tmp_dir', self.tmp_dir)

# Determine which version we have and which version we want.

timestamp_file = 'TIMESTAMP_LAST_UPLOAD_COMPLETED'

@@ -246,7 +246,7 @@ class SkiaApi(recipe_api.RecipeApi):

def download_and_copy_skps(self):

"""Download the SKPs if needed."""

# Ensure that the tmp_dir exists.

- self._run_once(self.m.path.makedirs, 'tmp_dir', self.tmp_dir)

+ self._run_once(self.m.file.makedirs, 'tmp_dir', self.tmp_dir)

# Determine which version we have and which version we want.

version_file = 'SKP_VERSION'

« no previous file with comments | « scripts/slave/recipe_modules/pgo/api.py ('k') | scripts/slave/recipe_modules/skia/default_flavor.py » ('j') | no next file with comments »