Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1101593002: Revert of Add tokens and entry points for KHR_blend_equation_advanced (Closed)

Created:
5 years, 8 months ago by tomhudson
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add tokens and entry points for KHR_blend_equation_advanced (patchset #3 id:40001 of https://codereview.chromium.org/1039693004/) Reason for revert: We're getting repeated crashes since this CL landed when we try to evaluate a roll into Chrome on our bots. (https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1902) Our initial reflex is to put a #if 0 around this code (just like the immediately following lines 334-338 in GrGLInterface.cpp), but the error isn't what the GPU team expected to see if that was all we needed, so we're reverting now and asking you to resubmit tomorrow after running more thorough tests. Original issue's description: > Add tokens and entry points for KHR_blend_equation_advanced > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8e578859f80b46a63144add215955221017d3609 TBR=markkilgard@gmail.com,bsalomon@google.com,cdalton@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2575f317d3fa977676279097332955c20ad46044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -79 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -3 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +5 lines, -27 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tomhudson
Created Revert of Add tokens and entry points for KHR_blend_equation_advanced
5 years, 8 months ago (2015-04-21 21:16:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101593002/1
5 years, 8 months ago (2015-04-21 21:16:41 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 21:16:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2575f317d3fa977676279097332955c20ad46044

Powered by Google App Engine
This is Rietveld 408576698