Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1100713002: Factor formal argument parsing into ParserBase (Closed)

Created:
5 years, 8 months ago by wingo
Modified:
5 years, 8 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Factor formal argument parsing into ParserBase This commit is a precursor to making lazy arrow function parsing use similar logic to function(){} argument parsing. Originally landed in these three CLs: https://codereview.chromium.org/1078093002 https://codereview.chromium.org/1083623002 https://codereview.chromium.org/1083953002 These were rolled out due to a performance regression on CodeLoad. This patchset will fix that by avoiding creation of a DuplicateFinder in the full parser. R=marja@chromium.org BUG= LOG=N Committed: https://crrev.com/636cb4f365afe93de37685a69a9b8bfd16a9f70f Cr-Commit-Position: refs/heads/master@{#27960}

Patch Set 1 #

Patch Set 2 : Avoid DuplicateFinder creation in the full parser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -212 lines) Patch
M src/messages.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/parser.h View 1 3 chunks +17 lines, -2 lines 0 comments Download
M src/parser.cc View 1 8 chunks +35 lines, -91 lines 0 comments Download
M src/preparser.h View 1 17 chunks +180 lines, -51 lines 0 comments Download
M src/preparser.cc View 1 2 chunks +15 lines, -54 lines 0 comments Download
M src/scopes.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A + test/message/formal-parameters-bad-rest.js View 1 chunk +2 lines, -2 lines 0 comments Download
A test/message/formal-parameters-bad-rest.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/formal-parameters-strict-body.js View 1 chunk +1 line, -3 lines 0 comments Download
A test/message/formal-parameters-strict-body.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/formal-parameters-trailing-comma.js View 1 chunk +1 line, -3 lines 0 comments Download
A test/message/formal-parameters-trailing-comma.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/strict-formal-parameters.js View 1 chunk +2 lines, -3 lines 0 comments Download
A test/message/strict-formal-parameters.out View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wingo
This is the purely refactoring bits of https://codereview.chromium.org/1064433008/, split out into a new hopefully easier-to-read ...
5 years, 8 months ago (2015-04-21 10:32:34 UTC) #2
marja
lgtm based on discussions & reviews in https://codereview.chromium.org/1064433008/ and the previous version
5 years, 8 months ago (2015-04-21 10:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100713002/40001
5 years, 8 months ago (2015-04-21 10:43:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-21 11:09:57 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/636cb4f365afe93de37685a69a9b8bfd16a9f70f Cr-Commit-Position: refs/heads/master@{#27960}
5 years, 8 months ago (2015-04-21 11:10:07 UTC) #7
marja
5 years, 8 months ago (2015-04-21 12:06:23 UTC) #8
Message was sent while issue was closed.
At the moment, the performance bots look happy.. no visible regressions. To
confirm for realz we need a couple of more runs.

Powered by Google App Engine
This is Rietveld 408576698