Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1083953002: Fix FormalParameterErrorLocations member names (Closed)

Created:
5 years, 8 months ago by wingo
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix FormalParameterErrorLocations member names R=arv@chromium.org BUG= Committed: https://crrev.com/53ddccfc33f7052429e3261e15a2bbabb05760b3 Cr-Commit-Position: refs/heads/master@{#27858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M src/parser.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/preparser.h View 4 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wingo
5 years, 8 months ago (2015-04-14 15:23:51 UTC) #1
arv (Not doing code reviews)
LGTM Thanks
5 years, 8 months ago (2015-04-15 20:37:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083953002/1
5 years, 8 months ago (2015-04-15 20:38:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 21:08:19 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:08:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53ddccfc33f7052429e3261e15a2bbabb05760b3
Cr-Commit-Position: refs/heads/master@{#27858}

Powered by Google App Engine
This is Rietveld 408576698