Refactor formal parameter error locations into a class

Refactor formal parameter error locations into a class

This is a follow-up to https://codereview.chromium.org/1078093002.

R=rossberg@chromium.org
BUG=

Committed: https://crrev.com/0f432ebb76350a69d59edc303c181c8ba1719c96
Cr-Commit-Position: refs/heads/master@{#27780}

[rossberg, 2015-04-13 09:12:17]

LGTM modulo comment

https://codereview.chromium.org/1083623002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1083623002/diff/1/src/preparser.h#newcode25
src/preparser.h:25: class FormalParameterErrorLocations BASE_EMBEDDED {
Could this be a local (protected?) class of PreParserBase?

[wingo, 2015-04-13 09:20:21]

On 2015/04/13 09:12:17, rossberg wrote:
> LGTM modulo comment
> 
> https://codereview.chromium.org/1083623002/diff/1/src/preparser.h
> File src/preparser.h (right):
> 
> https://codereview.chromium.org/1083623002/diff/1/src/preparser.h#newcode25
> src/preparser.h:25: class FormalParameterErrorLocations BASE_EMBEDDED {
> Could this be a local (protected?) class of PreParserBase?

I tried to make it a protected class of ParserBase but the traits classes need
access to its structure, in order to pick out e.g. the "undefined" error loc,
and as traits have different expression representations this appears to be
necessary.  I couldn't think of a better way to handle this.  I'll leave the
ticket open for a couple hours in case either of us gets an inspirational
brain-wave though.

[rossberg, 2015-04-13 09:58:19]

On 2015/04/13 09:20:21, wingo wrote:
> On 2015/04/13 09:12:17, rossberg wrote:
> > LGTM modulo comment
> > 
> > https://codereview.chromium.org/1083623002/diff/1/src/preparser.h
> > File src/preparser.h (right):
> > 
> > https://codereview.chromium.org/1083623002/diff/1/src/preparser.h#newcode25
> > src/preparser.h:25: class FormalParameterErrorLocations BASE_EMBEDDED {
> > Could this be a local (protected?) class of PreParserBase?
> 
> I tried to make it a protected class of ParserBase but the traits classes need
> access to its structure, in order to pick out e.g. the "undefined" error loc,
> and as traits have different expression representations this appears to be
> necessary.  I couldn't think of a better way to handle this.  I'll leave the
> ticket open for a couple hours in case either of us gets an inspirational
> brain-wave though.

I see. I'm fine with leaving it alone then.

[wingo, 2015-04-13 10:14:08]

The CQ bit was checked by wingo@igalia.com

[commit-bot: I haz the power, 2015-04-13 10:14:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083623002/1

[commit-bot: I haz the power, 2015-04-13 10:39:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-13 10:39:52]

Patchset 1 (id:??) landed as
https://crrev.com/0f432ebb76350a69d59edc303c181c8ba1719c96
Cr-Commit-Position: refs/heads/master@{#27780}

[arv (Not doing code reviews), 2015-04-13 14:24:17]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-04-13 14:24:17]

LGTM

https://codereview.chromium.org/1083623002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1083623002/diff/1/src/preparser.h#newcode33
src/preparser.h:33: Scanner::Location eval_or_arguments_;
Nit: public fields should not end with underscore.

[wingo, 2015-04-13 14:59:26]

On 2015/04/13 14:24:17, arv wrote:
> LGTM
> 
> https://codereview.chromium.org/1083623002/diff/1/src/preparser.h
> File src/preparser.h (right):
> 
> https://codereview.chromium.org/1083623002/diff/1/src/preparser.h#newcode33
> src/preparser.h:33: Scanner::Location eval_or_arguments_;
> Nit: public fields should not end with underscore.

Tx, will fix in a followup.