Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100233002: [Telemetry] Enable more lint checks for telemetry/. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Enable more lint checks for telemetry/. BUG=475714 Committed: https://crrev.com/9de0d226b3e6eda5fa690c163c55e354930b3b51 Cr-Commit-Position: refs/heads/master@{#326588}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address Ethan's comment #

Patch Set 3 : fix testComputeFrameTimeMetricWithNotEnoughFrames2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M tools/telemetry/pylintrc View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/util/bootstrap.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/layout_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
nednguyen
5 years, 8 months ago (2015-04-22 22:38:27 UTC) #4
eakuefner
lgtm, but i hope this isn't going to get reverted like https://codereview.chromium.org/1100233002 https://codereview.chromium.org/1100233002/diff/40001/tools/telemetry/telemetry/value/value_unittest.py File tools/telemetry/telemetry/value/value_unittest.py ...
5 years, 8 months ago (2015-04-22 22:50:19 UTC) #5
nednguyen
https://codereview.chromium.org/1100233002/diff/40001/tools/telemetry/telemetry/value/value_unittest.py File tools/telemetry/telemetry/value/value_unittest.py (right): https://codereview.chromium.org/1100233002/diff/40001/tools/telemetry/telemetry/value/value_unittest.py#newcode180 tools/telemetry/telemetry/value/value_unittest.py:180: def testAsDictWithoutDescription2(self): On 2015/04/22 22:50:19, eakuefner wrote: > Should ...
5 years, 8 months ago (2015-04-22 23:23:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100233002/60001
5 years, 8 months ago (2015-04-22 23:24:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/49779)
5 years, 8 months ago (2015-04-23 02:33:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100233002/80001
5 years, 8 months ago (2015-04-23 16:30:39 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 8 months ago (2015-04-23 18:32:29 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 18:33:43 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9de0d226b3e6eda5fa690c163c55e354930b3b51
Cr-Commit-Position: refs/heads/master@{#326588}

Powered by Google App Engine
This is Rietveld 408576698