tools/telemetry/telemetry/value/value_unittest.py - Issue 1100233002: [Telemetry] Enable more lint checks for telemetry/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/value_unittest.py

Issue 1100233002: [Telemetry] Enable more lint checks for telemetry/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix testComputeFrameTimeMetricWithNotEnoughFrames2 Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/value/value_unittest.py

diff --git a/tools/telemetry/telemetry/value/value_unittest.py b/tools/telemetry/telemetry/value/value_unittest.py

index 21bd5af2291ee19aa21895ece39eca22c51dad30..6e8f7f43d330ff7755f2b0f8661ff692f2b0b679 100644

--- a/tools/telemetry/telemetry/value/value_unittest.py

+++ b/tools/telemetry/telemetry/value/value_unittest.py

@@ -177,7 +177,7 @@ class ValueTest(TestBase):

d = v.AsDict()

self.assertEqual('foo', d['tir_label'])

- def testAsDictWithoutDescription(self):

+ def testAsDictWithoutInteractionRecord(self):

v = ValueForAsDictTest(None, 'x', 'unit', important=False, description=None,

tir_label=None)

self.assertNotIn('tir_label', v.AsDict())

« no previous file with comments | « tools/telemetry/telemetry/util/bootstrap.py ('k') | tools/telemetry/telemetry/web_perf/metrics/layout_unittest.py » ('j') | no next file with comments »