Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1099783003: Reland Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)
Modified:
5 years, 8 months ago
Reviewers:
ulan, akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. BUG= Committed: https://crrev.com/ee59bde7037edf14e46541efccc2ebcd9d275ea1 Cr-Commit-Position: refs/heads/master@{#28024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -219 lines) Patch
M src/heap/heap.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 69 chunks +83 lines, -85 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-constantpool.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 61 chunks +87 lines, -85 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 8 months ago (2015-04-22 08:42:40 UTC) #2
ulan
lgtm
5 years, 8 months ago (2015-04-22 10:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099783003/1
5 years, 8 months ago (2015-04-23 08:36:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 08:37:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee59bde7037edf14e46541efccc2ebcd9d275ea1 Cr-Commit-Position: refs/heads/master@{#28024}
5 years, 8 months ago (2015-04-23 08:37:41 UTC) #7
akos.palfi.imgtec
5 years, 8 months ago (2015-04-23 19:56:58 UTC) #9
Message was sent while issue was closed.
Fixes Threading2 test on mips no-snap bots
(http://build.chromium.org/p/client.v8/builders/V8%20Mips%20-%20big%20endian%2...).
Due to differing test order on mips (caused by toolchain static constructor
initialization differences), InternalFieldCallback test fell exactly into this
gap where incremental marking GC had started, preventing a full GC, though test
required full GC to pass.

Thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698