test/cctest/test-accessors.cc - Issue 1099783003: Reland Force full GCwhenever CollectAllGarbage is meant to trigger a full GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-accessors.cc

Issue 1099783003: Reland Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-accessors.cc

diff --git a/test/cctest/test-accessors.cc b/test/cctest/test-accessors.cc

index be69111364284581d6f5abf156facddba9a7d431..ac631757b2863c4b5ab4b91b5026086a0b75b1de 100644

--- a/test/cctest/test-accessors.cc

+++ b/test/cctest/test-accessors.cc

@@ -277,7 +277,7 @@ static void CheckAccessorArgsCorrect(

CHECK(info.This() == info.Holder());

CHECK(

info.Data()->Equals(v8::String::NewFromUtf8(CcTest::isolate(), "data")));

- CcTest::heap()->CollectAllGarbage(i::Heap::kNoGCFlags);

+ CcTest::heap()->CollectAllGarbage();

CHECK(info.GetIsolate() == CcTest::isolate());

CHECK(info.This() == info.Holder());

CHECK(

« no previous file with comments | « src/heap/mark-compact-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »