test/cctest/test-mark-compact.cc - Issue 1099783003: Reland Force full GCwhenever CollectAllGarbage is meant to trigger a full GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-mark-compact.cc

Issue 1099783003: Reland Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-mark-compact.cc

diff --git a/test/cctest/test-mark-compact.cc b/test/cctest/test-mark-compact.cc

index aa51bea31cb1ac5eea78c4b80db390e1496d88f0..5b7fe56133d128267a0d37972dcd129a12d92d38 100644

--- a/test/cctest/test-mark-compact.cc

+++ b/test/cctest/test-mark-compact.cc

@@ -92,8 +92,8 @@ TEST(Promotion) {

CHECK(heap->InSpace(*array, NEW_SPACE));

// Call mark compact GC, so array becomes an old object.

- heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);

+ heap->CollectAllGarbage();

// Array now sits in the old space

CHECK(heap->InSpace(*array, OLD_SPACE));

« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-mementos.cc » ('j') | no next file with comments »