Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1099483002: Use alias_for with trivial property aliases (Closed)

Created:
5 years, 8 months ago by Timothy Loh
Modified:
5 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@alias
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use alias_for with trivial property aliases This patch updates the following properties to use the new alias_for code-path, reducing how many places need to know about these. -webkit-box-shadow -webkit-perspective-origin -webkit-transform-origin -webkit-transform-style -webkit-backface-visibility BUG=410112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194038

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase a couple of tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -86 lines) Patch
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/styles/svg-style-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 1 2 8 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/transforms/webkit-perspective-origin-csstext.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/transitions/unprefixed-perspective-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/transitions/unprefixed-transform-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 4 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 4 chunks +0 lines, -5 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 5 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSProperties.in View 6 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 5 chunks +2 lines, -7 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 4 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 7 chunks +7 lines, -10 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Timothy Loh
Depends on https://codereview.chromium.org/1096963002/ https://codereview.chromium.org/1099483002/diff/1/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt File LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (left): https://codereview.chromium.org/1099483002/diff/1/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt#oldcode118 LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:118: -webkit-backface-visibility: visible; alias_for properties are not ...
5 years, 8 months ago (2015-04-20 01:31:55 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 8 months ago (2015-04-20 07:00:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099483002/40001
5 years, 8 months ago (2015-04-20 12:15:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099483002/60001
5 years, 8 months ago (2015-04-20 14:23:40 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 17:05:56 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194038

Powered by Google App Engine
This is Rietveld 408576698