Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: Source/core/animation/StringKeyframe.cpp

Issue 1099483002: Use alias_for with trivial property aliases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@alias
Patch Set: rebase a couple of tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/StringKeyframe.h" 6 #include "core/animation/StringKeyframe.h"
7 7
8 #include "core/animation/AngleSVGInterpolation.h" 8 #include "core/animation/AngleSVGInterpolation.h"
9 #include "core/animation/ColorStyleInterpolation.h" 9 #include "core/animation/ColorStyleInterpolation.h"
10 #include "core/animation/CompositorAnimations.h" 10 #include "core/animation/CompositorAnimations.h"
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 if (interpolation) 326 if (interpolation)
327 return interpolation.release(); 327 return interpolation.release();
328 328
329 // FIXME: Handle keywords: top, right, left, center, bottom 329 // FIXME: Handle keywords: top, right, left, center, bottom
330 fallBackToLegacy = true; 330 fallBackToLegacy = true;
331 331
332 break; 332 break;
333 } 333 }
334 334
335 case CSSPropertyBoxShadow: 335 case CSSPropertyBoxShadow:
336 case CSSPropertyTextShadow: 336 case CSSPropertyTextShadow: {
337 case CSSPropertyWebkitBoxShadow: {
338 RefPtrWillBeRawPtr<Interpolation> interpolation = ListStyleInterpolation <ShadowStyleInterpolation>::maybeCreateFromList(*fromCSSValue, *toCSSValue, prop erty); 337 RefPtrWillBeRawPtr<Interpolation> interpolation = ListStyleInterpolation <ShadowStyleInterpolation>::maybeCreateFromList(*fromCSSValue, *toCSSValue, prop erty);
339 if (interpolation) 338 if (interpolation)
340 return interpolation.release(); 339 return interpolation.release();
341 340
342 // FIXME: AnimatableShadow incorrectly animates between inset and non-in set values so it will never indicate it needs default interpolation 341 // FIXME: AnimatableShadow incorrectly animates between inset and non-in set values so it will never indicate it needs default interpolation
343 if (ShadowStyleInterpolation::usesDefaultStyleInterpolation(*fromCSSValu e, *toCSSValue)) { 342 if (ShadowStyleInterpolation::usesDefaultStyleInterpolation(*fromCSSValu e, *toCSSValue)) {
344 forceDefaultInterpolation = true; 343 forceDefaultInterpolation = true;
345 break; 344 break;
346 } 345 }
347 346
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 RefPtrWillBeRawPtr<SVGPropertyBase> fromValue = attribute->currentValueBase( )->cloneForAnimation(m_value); 495 RefPtrWillBeRawPtr<SVGPropertyBase> fromValue = attribute->currentValueBase( )->cloneForAnimation(m_value);
497 RefPtrWillBeRawPtr<SVGPropertyBase> toValue = attribute->currentValueBase()- >cloneForAnimation(toSVGPropertySpecificKeyframe(end).value()); 496 RefPtrWillBeRawPtr<SVGPropertyBase> toValue = attribute->currentValueBase()- >cloneForAnimation(toSVGPropertySpecificKeyframe(end).value());
498 497
499 if (!fromValue || !toValue) 498 if (!fromValue || !toValue)
500 return nullptr; 499 return nullptr;
501 500
502 return createSVGInterpolation(fromValue.get(), toValue.get(), attribute.get( )); 501 return createSVGInterpolation(fromValue.get(), toValue.get(), attribute.get( ));
503 } 502 }
504 503
505 } 504 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698